Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credits section + install documentation #91

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Credits section + install documentation #91

merged 10 commits into from
Oct 5, 2023

Conversation

bclenet
Copy link
Collaborator

@bclenet bclenet commented Sep 19, 2023 •
edited
Loading

Changes proposed in this Pull Request:

  • Added contributors to credits section of README.md
  • Simplifying the install documentation

Checklist:

  • Descriptive title
  • Targets the main branch
  • Changes are functional
  • My code is explicit and comments were added to it
  • Code conforms with PEP8
  • Tests were added for the changes and they complete successfully
  • Existing tests were updated (if needed) and they complete successfully
  • Documentation was updated

@bclenet bclenet changed the title Adding contributors to credits section Credits section + install documentation Sep 20, 2023
@bclenet bclenet marked this pull request as ready for review September 20, 2023 14:48
@cmaumet
Copy link
Contributor

cmaumet commented Oct 3, 2023

@bclenet: thanks for this! I have reviewed the updates and those looks good to me. If you are okay, I think this is good to merge!

@bclenet bclenet merged commit 5b375cc into Inria-Empenn:main Oct 5, 2023
1 check passed
@bclenet bclenet deleted the credits branch January 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaumet cmaumet Awaiting requested review from cmaumet

@elodiegermani elodiegermani Awaiting requested review from elodiegermani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bclenet @cmaumet